Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: env DSN to be included if hydra.dsn is empty #520

Closed
wants to merge 3 commits into from
Closed

fix: env DSN to be included if hydra.dsn is empty #520

wants to merge 3 commits into from

Conversation

cr1cr1
Copy link

@cr1cr1 cr1cr1 commented Sep 30, 2022

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

hydra-automigrate will fail if using a secret instead of explicit hdyra.dsn because wrong condition in the helm template:

k8s/helm/charts/hydra/templates/job-migration.yaml

Line 60 in 6a22a34

{{- if not (empty ( include "hydra.dsn" . )) }}

This bug was introduced in release v0.25.4

@cr1cr1 cr1cr1 changed the title [hydra] env DSN to be included if hydra.dsn is empty [fix] env DSN to be included if hydra.dsn is empty Sep 30, 2022
@cr1cr1 cr1cr1 changed the title [fix] env DSN to be included if hydra.dsn is empty fix: env DSN to be included if hydra.dsn is empty Sep 30, 2022
Demonsthere
Demonsthere requested changes Oct 5, 2022
View reviewed changes
helm/charts/hydra/Chart.yaml Outdated Show resolved Hide resolved
helm/charts/hydra/templates/job-migration.yaml Show resolved Hide resolved
@MOZGIII
Copy link

MOZGIII commented Oct 21, 2022

Not passing the DSN is actually a feature: you can pass a custom dynamically constructed DSN vie extraEnv.

@Demonsthere
Copy link
Collaborator

closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demonsthere Demonsthere Demonsthere requested changes

@piotrmsc piotrmsc Awaiting requested review from piotrmsc piotrmsc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cr1cr1 @MOZGIII @Demonsthere